desihub / desispec

DESI spectral pipeline
BSD 3-Clause "New" or "Revised" License
33 stars 24 forks source link

Jura exposure_tables overrides for missing darks #2255

Closed sbailey closed 1 month ago

sbailey commented 1 month ago

Creating a non-code ticket to document what I did for Jura:

Nights 20210106, 20210314, 20210519, 20230309, 20231220 and thus needed an override file entry to link the badcolumns files.

Symptom:

NIGHT=20210106
desi_proc_night -n $NIGHT --dry-run-level 3
--> "Exiting because not all calibration files accounted for with links or submissions"

Fix:

desi_create_override_file -n $NIGHT --no-ff-solve-grad
--> previous night as reference night, yes to everything except darks

Result: exposure_tables/202101/override_20210106.yaml created with:

# DESI override file for 20210106
# linkcal notes: current night's bias,cte flats,psfs,flats were ok; badcols were bad

calibration:
  linkcal:
    include: badcolumns
    refnight: 20210105

Previous test passes:

desi_proc_night -n $NIGHT --dry-run-level 3
--> All done: Completed submission of exposures for night 20210106

I did this for nights 20210106, 20210314, 20210519, 20230309. Night 20231220 was handled somewhat differently since its ref night is 20231217 (no data on 1218 or 1219) and it already had an override file for --autocal-ff-solve-grad, so its override file was augmented instead of created anew.

I committed these to exposure_tables svn.

akremin commented 1 month ago

I ran a check for calibration selection and cross-referenced them with override files. After grabbing the latest overrides from svn we now have complete coverage. Below I give a table of outputs for all nights where we don't have a complete set of calibrations, and give the override file list of cals to link. We see that everything matches up now.

Nd = number of darks, Nz = number of zeros, Na arcs, Nf flats

Filename                     Nd Nz Na Nf       
exposure_table_20210106.csv  0  31  5 12  files_to_link={'badcolumns'}
exposure_table_20210130.csv  1  38  5  0  files_to_link={'fiberflatnight'}
exposure_table_20210218.csv  1  25  5  0  files_to_link={'fiberflatnight'}
exposure_table_20210314.csv  0  23  5 12  files_to_link={'badcolumns'}
exposure_table_20210519.csv  0  20  5 12  files_to_link={'badcolumns'}
exposure_table_20211009.csv  1  26  5  0  files_to_link={'fiberflatnight'}
exposure_table_20211128.csv  0   0  5 12  files_to_link={'biasnight', 'badcolumns'}
exposure_table_20211212.csv  1  25  0  0  files_to_link={'ctecorrnight', 'psfnight', 'fiberflatnight'}
exposure_table_20220923.csv  1  35  0  0  files_to_link={'ctecorrnight', 'psfnight', 'fiberflatnight'}
exposure_table_20221120.csv  1  35  5  0  files_to_link={'ctecorrnight', 'fiberflatnight'}
exposure_table_20221222.csv  1  25  0  0  files_to_link={'ctecorrnight', 'psfnight', 'fiberflatnight'}
exposure_table_20221228.csv  1  95  0  0  files_to_link={'ctecorrnight', 'psfnight', 'fiberflatnight'}
exposure_table_20230309.csv  0  53  5 13  files_to_link={'badcolumns'}
exposure_table_20231018.csv  1  25  5  0  files_to_link={'ctecorrnight', 'fiberflatnight'}
exposure_table_20231216.csv  1  25  0  0  files_to_link={'ctecorrnight', 'psfnight', 'fiberflatnight'}
exposure_table_20231220.csv  0  35  5 13  files_to_link={'badcolumns'}