This PR updates plot_fiber_traces --fibers to accept "true" fiber numbers 0-4999, not just the index per camera 0-499. e.g. this fails in main but now works on this branch:
Previously this would have required --fibers 51 instead. That's not too hard in this case, but it's a pain when cutting-and-pasting lists of bad fibers from other cases, e.g. issue #2288 .
Caveats:
this just does fibers = fibers%500 so the above example also would have accepted --fibers 2551 and done the same thing, even though fiber 2551 is a legitimate fiber number on a completely different camera. User beware. It appears that the input PSF only knows its "true" fiber range via interpreting the CAMERA keyword; the FIBERMIN/FIBERMAX keywords are not the true full range fiber numbers. Maybe we could/should parse CAMERA to not plot fibers that aren't on this particular petal, but that would actually break the previous usage of --fibers 51 meaning "plot the 51st fiber in this PSF regardless of camera number". i.e. I have prioritized not breaking prior uses of plot_fiber_traces over purity of what --fibers could/should mean.
This PR updates
plot_fiber_traces --fibersto accept "true" fiber numbers 0-4999, not just the index per camera 0-499. e.g. this fails in main but now works on this branch:Previously this would have required
--fibers 51instead. That's not too hard in this case, but it's a pain when cutting-and-pasting lists of bad fibers from other cases, e.g. issue #2288 .Caveats:
fibers = fibers%500so the above example also would have accepted--fibers 2551and done the same thing, even though fiber 2551 is a legitimate fiber number on a completely different camera. User beware. It appears that the input PSF only knows its "true" fiber range via interpreting the CAMERA keyword; the FIBERMIN/FIBERMAX keywords are not the true full range fiber numbers. Maybe we could/should parse CAMERA to not plot fibers that aren't on this particular petal, but that would actually break the previous usage of--fibers 51meaning "plot the 51st fiber in this PSF regardless of camera number". i.e. I have prioritized not breaking prior uses ofplot_fiber_tracesover purity of what--fiberscould/should mean.