search

desihub / desispec

DESI spectral pipeline
BSD 3-Clause "New" or "Revised" License
36 stars 24 forks source link

specstatus compatibility fix #2384

Closed weaverba137 closed 1 month ago

weaverba137 commented 1 month ago

This PR removes the UPDATED column from a tiles table so it remains compatible with the specstatus table.

coveralls commented 1 month ago

Coverage Status

coverage: 30.198% (+0.004%) from 30.194% when pulling 513774ae27a3316eb9c2e909d51502f4721ec2c5 on tiles-specstatus-compatibility into d8630a46ff2b4ce8ee508ccb55d35cda8e48a205 on main.

weaverba137 commented 1 month ago

In addition @sbailey found a bug in desi_tsnr_afterburner that was placing EFFTIME_SPEC values in the GOALTYPE column. That should be fixed now.

sbailey commented 1 month ago

This fixes a bug in desi_tsnr_afterburner, and fixes a crash-inducing incompatibility with the new UPDATED column in the tiles-daily.csv file. We're still checking the impact of the patched changes in tiles-daily.csv and how they propagate to tiles-specstatus.ecsv, but these changes at minimum are necessary so I will merge this now.