desihub / desispec

DESI spectral pipeline
BSD 3-Clause "New" or "Revised" License
36 stars 24 forks source link

QL: make SKYRBAND meaningful #709

Open sbailey opened 6 years ago

sbailey commented 6 years ago

Testing http://desi-1.kpno.noao.edu:9090 using code from desispec #702 (now tag 0.25.0) and qlf #253, mostly looking at Observing History window and drill-downs.

SKYRBAND is exactly 100.00 for every science exposure, which smells like a placeholder. Make that an actual meaningful measurement.

@rkehoe

rkehoe commented 6 years ago

@sbailey. Sure. We did not have a calibration vector for flux calibration, but PR #707 now has that. We will have an update soon.

Srheft commented 6 years ago

@sbailey : this QA remained a placeholder for a long time for a few needed info on the input for the QA that were still in the air:

rkehoe commented 6 years ago

@sbailey. Just an update on this Issue, once we have the final flux calibration vector from @julienguy we can finish this QA, either as part of the current PR #721 or a subsequent PR.