search

desihub / desisurvey

Code for desi survey planning and implementation
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

support astropy 4.2; switch to github actions for testing #138

Closed sbailey closed 3 years ago

sbailey commented 3 years ago

This PR

  1. fixes #137 by fixing the parsing of horizons moon ephem under astropy 4.2
  2. fixes #133 by switching from travis to github actions for CI testing

I suspect that (2) will take me a few more iterations to get the config right, so apologies in advance for the spam while I test the tests.

sbailey commented 3 years ago

@weaverba137 could you setup a COVERALLS_REPO_TOKEN for desisurvey? I'm not sure if we ever had coveralls configured for desisurvey, and/or what the procedure is to do that. Thanks.

weaverba137 commented 3 years ago

Done!

sbailey commented 3 years ago

Thanks @weaverba137 .

@dkirkby @schlafly I think this is a straightforward PR to replace travis tests with github actions, and to fix tests under astropy 4.2 . It does not change any core code (only tests). I'll leave this open for a bit if you have any comments or requests, but otherwise I plan to merge this by the end of today and make a new desisurvey tag.

schlafly commented 3 years ago

Let me just thank you for fixing this. I don't see any issues. Feel free to merge.

dkirkby commented 3 years ago

Yes, thanks @weaverba137!