Depth first - Githubissues

desihub / desisurvey

Code for desi survey planning and implementation

BSD 3-Clause "New" or "Revised" License

2 stars 7 forks source link

Depth first #66

Closed dkirkby closed 7 years ago

dkirkby commented 7 years ago

This PR adds the following features:

Implement an optional depth-first survey strategy (via rules-depth.yaml)
Add progress columns to track fiber assignment and planning (fixes #18)
Add set_value() method for config nodes (fixes #49)
Adds E(B-V) column to progress (fixes #54)

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 56.647% when pulling f6bd9102b83fa3591ecc016df24769f356d820d7 on depth_first into fc4f794158a518f392f8b3642918e3d80f1bc843 on master.

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 56.636% when pulling 37071add1dec6553ca024a75c44bab50b5e50b85 on depth_first into fc4f794158a518f392f8b3642918e3d80f1bc843 on master.

dkirkby commented 7 years ago

I am still working on an issue with surveymovie so this is not ready to merge yet.

dkirkby commented 7 years ago

This is ready to merge now.

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 56.636% when pulling ebaf5deb6947aa4095a7aa9786988cee03c19042 on depth_first into fc4f794158a518f392f8b3642918e3d80f1bc843 on master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 56.595% when pulling 0d51d17674df8ca8e3e9520e76fa7e489828ccd9 on depth_first into fc4f794158a518f392f8b3642918e3d80f1bc843 on master.

sbailey commented 7 years ago

Regarding the progress columns: these are the "covered", "available", and "planned" columns? They are integer days since start of survey (not dates or MJDs)? For the record could you define (again) the difference between "available" and "planned"? i.e. what's the recipe for knowing when to run fiber assignment on what tiles?

Clarifying: whether a tile is "covered" or not depends upon the rules file, correct? Or is it just "all tiles from previous layers that cover this tile have now been observed" regardless of whether the rules file says you should wait for them or not?

Code looks fine to merge, but I'd like to document how to use those progress columns.

sbailey commented 7 years ago

I now see that you defined when to run fiberassignment in issue #24:

adds a column available to the progress fits file that records the day number (defined by a new desisurvey.utils.day_number() function) on which the fibers for each tile are assigned. With the default monthly fiber-assignment cadence, this will always fall on the day closest to a full moon.

dkirkby commented 7 years ago

Clarifying: whether a tile is "covered" or not depends upon the rules file, correct?

Correct. In particular, this section of config.yaml determines which passes are pre-requisites for each pass (P0-3 = DARK, P4 = GRAY, P5-7 = BRIGHT):

fiber_assignment_order:
    P1: P0
    P2: P0+P1
    P3: P0+P1
    P6: P5
    P7: P5+P6

I decided to treat this as config, rather than hardcoded, since we currently treat P3 differently from other DARK layers. Also, note that:

P1: P0
P2: P0+P1

is subtly different from:

P1: P0
P2: P1

(but I think this only matters at the edges).