do not assume that input tile file includes all of DARK, BRIGHT, and GRAY tiles

desihub / desisurvey

Code for desi survey planning and implementation

BSD 3-Clause "New" or "Revised" License

2 stars 7 forks source link

do not assume that input tile file includes all of DARK, BRIGHT, and GRAY tiles #83

Closed moustakas closed 6 years ago

moustakas commented 6 years ago

The changes in this simple PR are to accommodate the SV Data Challenge.

surveyinit currently assumes that the tile file includes a mixture of DARK, BRIGHT, and GRAY tiles, and crashed when I gave it a minimal tile file with just DARK tiles, and so I added a simple if statement to check.

The second change (to surveymovie) was to use uppercase column names when grabbing data from the exposures.fits file (which perhaps was standardized elsewhere / previously?).

dkirkby commented 6 years ago

I wouldn't be surprised if something else breaks with only DARK tiles (which will be good to know), but this is already an improvement so go ahead and merge when convenient.