New secondary bits for the COSMOS dedicated programs and for unusual point sources.

desihub / desitarget

DESI Targeting

BSD 3-Clause "New" or "Revised" License

18 stars 23 forks source link

New secondary bits for the COSMOS dedicated programs and for unusual point sources. #682

Closed geordie666 closed 3 years ago

geordie666 commented 3 years ago

This PR:

updates the SV1 secondary targeting bits with the latest (final) versions for the dedicated programs in COSMOS.
deprecates some earlier bits for those COSMOS programs which correspond to defunct selections.
adds the bits for the unusual point sources secondary program (PSF_OUT_BRIGHT, PSF_OUT_DARK).

There is no new code, other than updating bit-masks, so I'll merge as soon as tests pass to make a new tag for the new secondary targets.

coveralls commented 3 years ago

Coverage remained the same at 60.17% when pulling 925901264863f6809944bfb15f6b21a017269fe4 on ADM-sec-cosmos into 2e62f51ca8f31516b8f0a864ee32164e4b9da12a on master.

sbailey commented 3 years ago

@geordie666 can you confirm that the deprecated/replaced bits were never used for tiles that were observed?

geordie666 commented 3 years ago

I can't. Unfortunately, because of the way secondary targeting works, if people request a similar targeting set multiple times there is no way to determine an unambiguous SCND_ORDER for those target classes. So, a new bit has to be cut and the previous bit has to be removed. The deprecated bits should all be for DEDICATED programs, though. So, people who are interested in DEDICATED secondary programs just need to remember to use the mask that corresponds to the version of the code used to process their targets. This is unfortunate, but I hadn't envisioned that we'd be updating secondary targets in official versions of the code 2, 3 even 4 times before observing DEDICATED tiles.