desihub / desitarget

DESI Targeting
BSD 3-Clause "New" or "Revised" License
19 stars 23 forks source link

Add EDR3 options to the code that writes the Gaia-matched sweeps #715

Closed geordie666 closed 3 years ago

geordie666 commented 3 years ago

This PR continues work to augment existing infrastructure in the gaiamatch module to work with Gaia EDR3. Existing functions are updated to have a dr kwarg to specify Gaia edr3 or dr2. In particular, the function and script that write Gaia-matched sweeps have been updated to produce EDR3 sweeps.

Example outputs of Gaia EDR3 sweeps are in:

/global/cscratch1/sd/adamyers/gaiaedr3match/*

which are row-by-row parallel to:

/global/cfs/cdirs/cosmo/data/legacysurvey/dr9/*/sweep/9.0/

I'm leaving this as a WIP until I've asked the MWS group to check the new sweeps.

geordie666 commented 3 years ago

I added code to this PR to also include a gaiasub keyword when running Main Survey targets. If the GAIA_DIR environment variable is set-up to point to the new Gaia EDR3 sweeps, then passing gaiasub causes EDR3 values of proper motion and parallax (and related errors/ivars) to be copied over the (Gaia DR2) values in the DR9 Legacy Surveys files.

This PR has been WIP for ~7 days and I haven't heard any feedback, so I'll merge soon.