desihub / desitarget

DESI Targeting
BSD 3-Clause "New" or "Revised" License
19 stars 23 forks source link

Lookup for dynamic sky fiber placement #722

Closed dstndstn closed 3 years ago

dstndstn commented 3 years ago

This is the code we're using in fiberassign to do the lookup for good sky locations in the "skybricks" data product. Stephen requested it go in desitarget so he can use it in the spectro pipeline.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.3%) to 59.213% when pulling 258973eb858f47a9c02e4d3374fd4f4f4afbc07c on dynamic-sky into 073e430c0c148756c0d2e79fcb28cf0b2c4ab589 on master.

geordie666 commented 3 years ago

@dstndstn: This PR looks fine, and it's OK to merge it. Before you do, though, make sure to update the changes documentation and the API for read-the-docs.

sbailey commented 3 years ago

Thanks; I also tested that this works as expected, and updated the changes.rst and api.rst so that @dstndstn can focus on other topics. I'll merge after tests re-pass.

dstndstn commented 3 years ago

Wow, thanks @sbailey!