Update baseline LRG selection

desihub / desitarget

DESI Targeting

BSD 3-Clause "New" or "Revised" License

18 stars 23 forks source link

Update baseline LRG selection #723

Closed rongpu closed 3 years ago

rongpu commented 3 years ago

This PR updates the baseline LRG selection (assuming it will be the final main survey selection). Changes from SV3 include:

Change the zfiber faint limit from 21.7 to 21.6
Change the low-z limit from z>0.3 to z>0.4
Change the overall density from 800/sq.deg. to 600/sq.deg.
Remove the LRG_LOWDENS target bit

coveralls commented 3 years ago

Coverage decreased (-0.02%) to 59.193% when pulling fd0c8ea76b12c2a69ef6df98f2ae0687d1ecfe24 on rongpu-lrg into e59fc8536824a7b5edba93737318587773643ac0 on master.

geordie666 commented 3 years ago

@rongpu: This all looks good to me, so no need for a detailed review.

One request. Can you update the docstring in isLRG() from:

- Current version (03/31/21) is version 15 on `the SV3 wiki`_.

- Current version (05/04/21) is version 254 on `the wiki`_.

Also, I think we can remove the LRG_LOWDENS bits from the bit-mask yaml file, as those bits have never been used in official Main Survey target catalogs. If you like, I can deprecate those in my working branch, though.

geordie666 commented 3 years ago

Thanks! I'll merge once tests pass.

rongpu commented 3 years ago

Thanks @geordie666. I've made the change in the docstring.

And yes, if you could remove the LRG_LOWDENS bits from the yaml file that would be great.