search

desihub / desitarget

DESI Targeting
BSD 3-Clause "New" or "Revised" License
18 stars 23 forks source link

z-band extinction correction #735

Closed mehdirezaie closed 2 years ago

mehdirezaie commented 3 years ago

Hi! I am interested in the extinction coefficients for W1 and W2, used for the calculation of MW_Transmission attributes. I found this function in the repository: https://github.com/desihub/desitarget/blob/acefce624846c54ac08261a85b297e99ba226da0/py/desitarget/mock/mockmaker.py#L321

However, I noticed that the z-band coefficient does not quite match the value reported in the documentation (Galactic Extinction Coefficients): https://www.legacysurvey.org/dr9/catalogs

moustakas commented 3 years ago

That's a typo in the z-band coefficient, @mehdirezaie, thanks (it should be 1.211, not 1.221).

But note that all the "dust" code has been consolidated into desiutil now (see https://github.com/desihub/desiutil/pull/169) and so I'll be refactoring this part of the code to use those extinction coefficients (which are consistent with what we used for the imaging).

moustakas commented 2 years ago

Fixed in #788.