Closed geordie666 closed 3 years ago
A few example ledgers that include timestamps that have been "forced" for every target class except MWS_FAINT
are available at NERSC in /global/cscratch1/sd/adamyers/PR739
.
@sbailey: I think this is ready to merge, and I'd like to merge it in about an hour so I can tackle the MTL loop after lunch without worrying about creating merge conflicts.
Thanks for the explanation, looks good. Merging now.
This PR adds an option to pass a timestamp when making initial ledgers. The passed timestamp will then be used in place of the
TIMESTAMP
column generated bymake_mtl()
.MWS_FAINT
targets can be exempted from this forced timestamp, and will instead adopt the usual "recent" timestamp generated bymake_mtl()
.The purpose of these changes is to address the issue where
1.0.0
ledgers (and target files) were generated withoutMWS_FAINT
targets, as fixed in #733. This PR should allow1.1.0
ledgers to be generated withTIMESTAMP
s that correspond to1.0.0
ledgers for all targets exceptMWS_FAINT
, as suggested by @sbailey.Some other minor updates are included in this PR:
ZS
andZINFO
are replaced byZ_QN
, as QuasarNP redshifts are the only non-redrock information that we'll be using to make LyA decisions.desitarget
functionality to read the never-to-be-spoken-of-again1.0.0
ledgers, then you'll have to use version1.0.0
ofdesitarget
.hpxlist
was passed towrite_secondary()
, that was introduced in #734, and was noticed by Anand has been fixed.