override_subpriority support duplicate TARGETID inputs

desihub / desitarget

DESI Targeting

BSD 3-Clause "New" or "Revised" License

18 stars 23 forks source link

override_subpriority support duplicate TARGETID inputs #743

Closed sbailey closed 3 years ago

sbailey commented 3 years ago

This PR adds support for duplicate TARGETID inputs in override_subpriority, while still using the faster geomask.match function when the inputs are unique. Duplicates can occur in secondary programs when more than one secondary matches a primary. Includes unit tests.

sbailey commented 3 years ago

Secondary run completes with

P=/global/cscratch1/sd/adamyers/ADMsecondary/outdata/1.0.1.dev5024/priminfo-dr9-1.0.1.dev5024/

select_secondary $P $CSCRATCH --scnddir /global/cscratch1/sd/adamyers/ADMsecondary \
--dark-subpriorities /global/cfs/cdirs/desi/target/catalogs/subpriority/fba-version-4.0.0/subpriorities-dark.fits \
--bright-subpriorities /global/cfs/cdirs/desi/target/catalogs/subpriority/fba-version-4.0.0/subpriorities-bright.fits

coveralls commented 3 years ago

Coverage increased (+0.04%) to 58.948% when pulling 0b3a7f5544b8b723ac39001157b9760dd10a2f56 on secondsubprio into 5c84622cefc66f5c5a2dc7ada8f60c8c564fbd0a on master.