Closed sbailey closed 3 years ago
Just to make absolutely sure, when POORDATA
is set, one of:
NODATA
BAD_SPECQA
BAD_PETALQA
is also always set, right? Otherwise we need an update in desitarget.mtl.make_mtl()
.
(and don't forget to update the changes file).
Tracing backwards:
So we're ok on the mtl side; merging now (and then will update change log in master)
Adds ZWARN bit 11 "POORDATA" which was recently added to the redrock ZWARN bitmask, and which desitarget unit tests properly caught hadn't been updated here yet. (background: desitarget doesn't depend upon redrock both to avoid circular dependencies and to simplify what is required for desitarget to run, but unit tests check that it's list of redrock ZWARN bits is current).
I think the equivalent of this bit is already propagated through tile QA and zmtl in FIBERSTATUS, so I don't think any change is needed on the MTL side, but I will leave this open for a cross check and/or a second look on a non-weekend day. The change on the redrock side was to set the bit for positioner offset > 30 microns at the time of running redrock, and not just post-facto as part of tile QA.