search

desihub / desitarget

DESI Targeting
BSD 3-Clause "New" or "Revised" License
18 stars 23 forks source link

fix code typos #770

Closed segasai closed 2 years ago

segasai commented 2 years ago

Fix 4 instances of variable names typos in cuts.py (probably most are harmless)

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 57.299% when pulling ed73324b3b7d4c0b75e8368ccee151d03026ff88 on typo_fixes into 1bf3e0c23586318cc83696d8765d4c22c36554a5 on master.

geordie666 commented 2 years ago

Thanks, Sergey. As you noted, most of these typos are in clauses that we don't actually trigger in the code. Some of the clauses were set up in a certain, formulaic way to facilitate working with mocks as well as with the real data.

The only typo that, I suppose, could have been harmful is the gaiamag = gaiagmag.copy() line. But, I think that will just lead to warnings on comparisons to NaN rather than affecting the actual selection.

In any case, feel free to merge this small PR after documenting it in doc/changes.rst.

segasai commented 2 years ago

Done. Thanks, Adam.