Add an ARCHIVEDATE column to the mtl done files and data model

desihub / desitarget

DESI Targeting

BSD 3-Clause "New" or "Revised" License

18 stars 23 forks source link

Add an ARCHIVEDATE column to the mtl done files and data model #773

Closed geordie666 closed 2 years ago

geordie666 commented 2 years ago

This PR adds an ARCHIVEDATE column to the data model for the MTL done files (mtl-done-tiles.ecsv and scnd-mtl-done-tiles.ecsv).

It also includes the convenience script that was used to add the intial ARCHIVEDATE values to the MTL done files.

coveralls commented 2 years ago

Coverage decreased (-0.004%) to 57.295% when pulling 35daec99b1fbaa6e89d8e2dfe1253161e47dcdc2 on ADM-arxiv-date into f7aef60cbc4e7a69d239e34b5960c7ad9bdfd517 on master.

geordie666 commented 2 years ago

Hold off on merging this. I need to make a change.

geordie666 commented 2 years ago

Should be good now. No further changes expected.

sbailey commented 2 years ago

Code looks good, with the caveat that I haven't tried running/testing it.

For consideration, I see that mtl-done-tiles.ecsv treats ZDATE and ARCHIVEDATE as strings, while tiles-specstatus.ecsv treats QANIGHT(=ZDATE), LASTNIGHT, and ARCHIVEDATE as integers, which is mildly inconvenient when matching the two files. Options:

mtl switches to int
we live with the discrepancy
(I'm not willing to switch tiles-specstatus to strings; I want to keep them as ints :)

I'll note that this discrepancy pre-dates this PR in ZDATE vs. QANIGHT+LASTNIGHT; ARCHIVEDATE just adds to the discrepancy.

geordie666 commented 2 years ago

As long as we're breaking backwards compatibility I can change those columns over to integers for ease-of-comparison. It'll take me a little time, though. So, we just have to remember to block MTL updates in the interim.

geordie666 commented 2 years ago

I made @sbailey's requested change. I'll merge this once tests pass and tag 2.0.0 so we can continue with "normal mode" MTL updates.