Skyhealpixs gaia v2 - Githubissues

desihub / desitarget

DESI Targeting

BSD 3-Clause "New" or "Revised" License

18 stars 23 forks source link

Skyhealpixs gaia v2 #776

Closed araichoor closed 2 years ago

araichoor commented 2 years ago

This PR is a small modification of the PR https://github.com/desihub/desitarget/pull/771. It introduces the following changes in skyhealpixs.py:

the healpix file basename now is skymap*, instead of gaia_skymap* (see [desi-survey 3412]);
the (nside, nest) values are now arguments, defaulting to the previously hard-coded values (64,True) (in case we want to test a different healpix scheme);
adds some log infos, expliciting the settings.

geordie666 commented 2 years ago

@araichoor: Can you please update the doc/changes.rst file to describe this PR?

araichoor commented 2 years ago

thanks again for the reminder, I ve just done it.

geordie666 commented 2 years ago

I think you need an _ after 776 in changes.rst? In any case, if tests pass then I'll just merge this PR and deal with that syntax myself when I make the tag.

araichoor commented 2 years ago

ah right, sorry: as we are not in rush, I can make the change now, let me know.

geordie666 commented 2 years ago

Good point, if you want to do that, great. As you say, I don't need to tag urgently. Thanks!

araichoor commented 2 years ago

typo corrected; apologies for that..