search

desihub / desitarget

DESI Targeting
BSD 3-Clause "New" or "Revised" License
18 stars 23 forks source link

Extra functionality for splitting random catalogs by HEALPixel #785

Closed geordie666 closed 2 years ago

geordie666 commented 2 years ago

This PR is an extension to #783.

Certain random catalogs already include an HPXPIXEL column, which #783 also added. This PR checks for the existence of an HPXPIXEL column before attempting to add it.

In addition, as random catalogs can be split in various ways, this PR adds a new directory name — based on the input random catalog filename — to the output HEALPixel-split directory structure. This makes it easier to track the location of — and better facilitates applying the desitarget.io reading routines to — HEALPixel-split random catalogs.

geordie666 commented 2 years ago

@ashleyjross: New versions of the HEALPixel-split randoms catalogs are available in:

/global/cscratch1/sd/adamyers/forashley/dr9/2.3.0.dev5334/randoms/resolve/randoms-1-*

These were built from the input catalogs:

/global/cfs/cdirs/desi/target/catalogs/dr9/0.49.0/randoms/resolve/randoms-1-*

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.04%) to 56.474% when pulling 6bc7af8e4088ac2a2069d9eba0774a09c2e16422 on ADM-more-hpx-rands into 2c4b585d64c6e02cb537bd36ec9f271f3230862c on master.

geordie666 commented 2 years ago

I'm going to merge this once tests pass. We can always revisit this later if the new style of random catalogs isn't as desired.