Closed geordie666 closed 2 years ago
@araichoor is checking the updates to the ToO mechanism from the fiberassign perspective. I'll likely merge this and cut a new desitarget tag once Anand is satisfied that everything gels.
I ve coded up the twin PR in fiberassign, which works fine for the main survey tiles.
one question though, when designing ToO-dedicated tile (maybe deprecated with the tertiary programs):
in the current fiberassign code, for a ToO-dedicated tile, will read ToO.ecsv
and select both TOO_TYPE="TILE" and "FIBER"
targets:
https://github.com/desihub/fiberassign/blob/854abc4d8c09250bb88855ee55be5d89a25fef38/py/fiberassign/fba_launch_io.py#L1637-L1638
with the current scheme, for that case, the code will read the ToO.ecsv
file, and hence just grab the TOO_TYPE="TILE"
targets.
(Adam, actually that the initial reason of my question on slack if ToO.ecsv
would contain both TOO_TYPE="TILE" and "FIBER"
targets; but I then forgot...)
maybe it s fine, but I just wanted to mention.
I think the case you describe is probably fine, Anand. I suspect we'll want to use the tertiary process in the future instead of TOO_TYPE="TILE"
. If not, then the ToO folks would just have to supply their targets as "TILE" targets instead of "FIBER" targets.
I'm going to merge this soon and make a new tag of desitarget. I have lots of meetings today, but I'll try to have a tag ready as soon as possible.
ok perfect then, thanks!
This PR updates how ToOs with
TOO_TYPE=="FIBER"
are handled. It also adds some new functionality for the override ledgers that we use to modify targets that are already in the MTL ledgers.Updates to the ToO functionality include:
TIMESTAMP
s for earlier ToOs.ToO-fiber.ecsv
file is now created forTOO_TYPE==FIBER
ToOs.ToO.ecsv
file for backwards-compatibility.ToO.ecsv
file will include all of the ToO observations to-date in the Main Survey, which have solely beenTOO_TYPE==TILE
observations.TOO_TYPE=TILE
observations will be scheduled through the more-flexible tertiary process.TOO_PRIO==HI
observations are now forbidden forTOO_TYPE==FIBER
ToOs in the Main Survey.Updates to the override-ledger functionality include:
scnd-mtl-done-overrides.ecsv
andmtl-done-overrides.ecsv
are now created/updated when target states are forced into the MTL ledgers using the override process.scnd-mtl-done-tiles.ecsv
andmtl-done-tiles.ecsv
files, but have zeroed-out tile-based information (as when we force override information into the MTL ledgers, we don't use any tile-based redshifts).done-overrides
files can be used by the alt MTLs to determine when forced overrides occurred, if needed.