Fix bug where data types are altered when override MTLs are empty

desihub / desitarget

DESI Targeting

BSD 3-Clause "New" or "Revised" License

18 stars 23 forks source link

Fix bug where data types are altered when override MTLs are empty #803

Closed geordie666 closed 1 year ago

geordie666 commented 1 year ago

This PR fixes a bug introduced when incorporating the MTL "override" ledgers into reprocessing.

When an override ledger didn't exist, or was otherwise empty, the data types for some columns were updated to standard types for an empty numpy array. This could then conflict with the data types for an overall ledger.

The fix is to never use standardized column updates for empty override ledgers.

coveralls commented 1 year ago

coverage: 56.291% (-0.004%) from 56.295% when pulling c33787304f811ce904919634721c22e35fa496b3 on ADM-fix-reproc into 3644d1b7091457f80080ad9f457a47acf38545ee on main.

sbailey commented 1 year ago

Update looks fine; thanks for sorting out photutils dependency pin for tests. OK to merge this when ready. Please open a separate ticket about the photutils dependency stuff.