Closed geordie666 closed 9 months ago
I'll leave this PR open until tomorrow evening and then I'll merge and make a new tag, mainly so we can deploy the work from PR #808 as part of daily operations.
While writing this PR, I discovered a bug that should be included in the DESI DR1 paper:
@geordie666, nice sleuthing. Can I please trouble to add (and self-assign) a ticket here-- https://github.com/desihub/dr1paper/issues
This PR has two main purposes:
While writing this PR, I discovered a bug that should be included in the DESI DR1 paper:
The string form of Booleans changed for the Gaia csv files moving from Gaia DR2 to Gaia EDR3, necessitating an update to how these strings were parsed. This update was not made, however, meaning that no Boolean columns could be interpreted as
True
for Gaia EDR3 or Gaia DR3. Therefore, all EDR3 or DR3 Gaia FITS files made by versions ofdesitarget
prior to this PR had Boolean columns set entirely toFalse
. The only column this would have affected for DESI targeting would be the GaiaDUPLICATED_SOURCE
column — i.e. effectively no source in DESI targeted using Gaia EDR3 (see section 4.1.4 of the desitarget paper) would have been masked onDUPLICATED_SOURCE
.This PR also adds a
boolfix
kwarg togaia_csv_to_fits()
allowing this bug to be corrected when generating Gaia EDR3 files. The default behavior ofgaia_csv_to_fits()
subsequent to this PR is:The bug does not affect Gaia DR2 files, either way.