search

desihub / desitarget

DESI Targeting
BSD 3-Clause "New" or "Revised" License
18 stars 23 forks source link

Prevent override ledgers from recording negative numbers of observations #810

Closed geordie666 closed 8 months ago

geordie666 commented 8 months ago

Currently, NUMOVERRIDE in the override ledgers will proceed from 2, 1, 0 to -1, -2, -3, etc. This doesn't actually seem to break anything, but it's messy and adds to unnecessary duplicated rows in the actual ledgers when targets are repeatedly overrode.

Fix the code to prevent additional overrides once NUMOVERRIDE is 0 in the override ledgers.

geordie666 commented 8 months ago

Closing this as I realized I already fixed this in 2.6.0 but go_mtl() had been using 2.5.0 of the desitarget code and so the fix wasn't applied when running the MTL loop. As we'll be using 2.7.0 for go_mtl() in the future, this should resolve itself.