Closed geordie666 closed 3 months ago
Unit tests will fail in this branch, but have been fixed in #814.
I think it's pretty clear in the documentation for select_targets
that only sweeps or Tractor files are valid inputs. I think that circumvents the possibility of having non-valid values of PHOTSYS
.
The code base does, indeed, handle Gaia-only and secondary target cases in other places.
This PR addresses #821 by only strictly setting bits for targets that pass the northern cuts in northern imaging, and vice versa, when resolving is turned on.
I tested this against the objects mentioned by @moustakas in #821, and the offending target bits are no longer set:
I also checked the
main
branch against thisbranch
for a couple of sweeps files (one from the north and one from the south), e.g.:All resulting targets and columns are identical. Some example output files are here: