search

desihub / desitarget

DESI Targeting
BSD 3-Clause "New" or "Revised" License
18 stars 23 forks source link

Clean up environment variables defined in desimodules #826

Closed weaverba137 closed 1 month ago

weaverba137 commented 1 month ago

As of desihub/desimodules#52, some environment variables will be defined in desimodules.

Please wait until the PR mentioned above is merged and deployed before merging.

coveralls commented 1 month ago

Coverage Status

coverage: 53.05%. remained the same when pulling cc566752de4f7fd069050a1baf06974a42a1342e on env-var-clean-up into 957645b29f5446cdfd818813a480186b08fb02f3 on main.

sbailey commented 1 month ago

FTR: I merged, updated changes.rst, reinstalled desitarget/main at NERSC, and verified that these environment variables are still set by "source desi_environment.sh main", but unlike before they are no longer unset by "module unload desitarget" (which is a good thing, because they are also needed by desispec).