desihub / desiutil

General DESI utilities, shell scripts, desiInstall, etc.
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

add desiutil.depend.mergedep + tests #164

Closed sbailey closed 3 years ago

sbailey commented 3 years ago

This PR adds desiutil.depend.mergedep as a utility function to merge DEPNAMnn + DEPVERnn dependencies+versions from one header into another. We messed this up with the blanc run by simply copying header keywords from one to the other, resulting in the same DEPNAMnn being listed more than once for different dependencies. This mergedep function takes care of rearranging numbers as needed. See the tests for examples.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.2%) to 68.046% when pulling 4d6af273b2b2c77dd1f6e2ac42e46dd90868eb3e on mergedeps into 9581e6ec591ccb78b868467ade2a69eed12f3503 on master.

weaverba137 commented 3 years ago

I'll try to review this evening.

sbailey commented 3 years ago

thanks, comments addressed, merging.