search

desihub / desiutil

General DESI utilities, shell scripts, desiInstall, etc.
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

add dust coefficients for DECam bands uiY #197

Closed moustakas closed 1 year ago

moustakas commented 1 year ago

Adds support for DR10 i-band and possible DR11 u- and Y-band.

coveralls commented 1 year ago

Coverage Status

coverage: 74.392%. remained the same when pulling 3f8dbcd9f5cc3109eb111a623c70fcb360711ea1 on dust-decam-uiy into 4f4b5947b04a929487e65120511cd8eadbcf2d36 on main.

moustakas commented 1 year ago

@weaverba137 I've decided to close this PR because the way the dust code is set is not flexible enough for what I'm doing in https://github.com/desihub/fastspecfit/pull/133. For example, in order to fit a general set of input photometry, which I'm extending FastSpecFit to be able to do, I need to be able to ignore the concept of a N/S photometric system (photsys) and I need to be able to have the same bandpasses from two different surveys (e.g., DECam g-band vs Subaru g-band).

Since desiutil.dust is a key part of the pipeline, I decided it was easier for me to move the MW dust correction step over to fastspecfit.util.mwdust_transmission.

weaverba137 commented 1 year ago

That's reasonable. Is it OK to delete the branch?

moustakas commented 1 year ago

I deleted the branch; thanks.