Open weaverba137 opened 1 year ago
To abandon backwards compatibility, we need:
python setup.py blat
, run blatfoo
instead" (see attempt below)pytest
doesn't work as-is on specsim and fiberassign and possibly othersAfter those have been completed, then we can remove support for setup.py itself for all packages en-masse, but let's not remove setup.py package-by-package until the new commands work everywhere so that we don't have to keep track of which packages require the old vs. new commands.
@weaverba137 please edit this comment to correct/expand this table as needed:
old command | new command |
---|---|
python setup.py test |
pytest |
python setup.py version |
desi_update_version |
python setup.py version --tag X.Y |
desi_update_version -t X.Y |
python setup.py build_sphinx |
sphinx-build doc/ build/sphinx/html (?) |
python setup.py install |
pip install . (?) |
python setup.py develop |
pip install --editable . (?) |
python setup.py build_ext --inplace |
??? (used by fiberassign and specex) |
The table already exists: https://desiutil.readthedocs.io/en/latest/helpers.html. Is that sufficient?
To be clear, we will still need python setup.py build_ext --inplace
for fiberassign
and specex
. I'm only proposing abandoning the enhancements provided by desiutil.setup
, not necessarily the top-level setup.py
file in packages.
The exception above only appeared when compiling documentation with Sphinx. Pinning Sphinx<7 in the test suite eliminates this error.
We still need to do the task of eliminating desiutil from various setup.py files, but for the purposes of desiutil, there is a workaround that will allow documentation builds to succeed.
During recent documentation tests, imports of
desiutil.setup
triggered errors related to importingsetuptools
.Since this is likely related to the deprecation of
setup.py
, we may need to abandon backward-compatible support fordesiutil
enhancements tosetup.py
sooner rather than later.We already have replacements for the functionality. The only thing needed here is a decision to abandon backward-compatibility.
Full traceback: