desihub / fastspecfit

Fast spectral synthesis and emission-line fitting of DESI spectra.
https://fastspecfit.readthedocs.org
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

more model padding when synthesizing photometry of highest-redshift targets #102

Closed moustakas closed 1 year ago

moustakas commented 1 year ago

Unfortunately, #101 didn't capture all the corner-case crashes of modeling the highest-redshift targets with respect to synthesizing model photometry. The models have a minimum (rest-frame) wavelength of 450 A, and so additional crashes were encountered while fitting Iron with the 2.1.1 version of the code.

I'm going to leave this PR open until all the other healpixels finish in case there are additional problems not previously identified.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4232879214


Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/fastspecfit.py 0 3 0.0%
py/fastspecfit/continuum.py 12 32 37.5%
<!-- Total: 13 36 36.11% -->
Files with Coverage Reduction New Missed Lines %
py/fastspecfit/continuum.py 1 72.06%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 4211399626: -0.2%
Covered Lines: 2209
Relevant Lines: 4147

💛 - Coveralls
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 4232879214

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/fastspecfit.py 0 3 0.0%
py/fastspecfit/continuum.py 12 32 37.5%
<!-- Total: 13 36 36.11% -->
Files with Coverage Reduction New Missed Lines %
py/fastspecfit/continuum.py 1 72.06%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 4211399626: -0.2%
Covered Lines: 2209
Relevant Lines: 4147

💛 - Coveralls