Corrected oii7320/oii7330 ratio

desihub / fastspecfit

Fast spectral synthesis and emission-line fitting of DESI spectra.

https://fastspecfit.readthedocs.org

BSD 3-Clause "New" or "Revised" License

13 stars 2 forks source link

Corrected oii7320/oii7330 ratio #120

Closed dirkscholte closed 1 year ago

dirkscholte commented 1 year ago

Corrected the emission line ratio of [OII]7320/[OII]7330 as explained in issue #119 . The emission line ratio was inverted with the refactoring of the code.

Before:

After:

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 4806940583

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.372%

Totals
Change from base Build 4788646963:	0.0%
Covered Lines:	2236
Relevant Lines:	4439

💛 - Coveralls

weaverba137 commented 1 year ago

Just a suggestion: when something like this can be easily reverted, one way to prevent that is to add a unit test specifically for this change, so that future reversions will cause the test to fail.