desihub / fastspecfit

Fast spectral synthesis and emission-line fitting of DESI spectra.
https://fastspecfit.readthedocs.org
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

fix dn4000 bug #135

Closed moustakas closed 1 year ago

moustakas commented 1 year ago

Fix #131.

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 5656415013


Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/fastspecfit.py 2 3 66.67%
<!-- Total: 6 7 85.71% -->
Files with Coverage Reduction New Missed Lines %
py/fastspecfit/fastspecfit.py 1 13.27%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 5587007847: 0.0%
Covered Lines: 2235
Relevant Lines: 4439

💛 - Coveralls
moustakas commented 1 year ago

To make sure I fixed the problem---and didn't introduce any new ones!---I ran about ~4000 BGS galaxies on tile 80613 through this branch and compared them with the Fuji/v2.0 VAC. (In retrospect, I should have used an LRG tile, but oh well.)

This figure clearly shows that the issue has been addressed.

Screenshot 2023-07-25 at 7 47 23 AM