update IGM attenuation model

desihub / fastspecfit

Fast spectral synthesis and emission-line fitting of DESI spectra.

https://fastspecfit.readthedocs.org

BSD 3-Clause "New" or "Revised" License

13 stars 2 forks source link

update IGM attenuation model #136

Closed moustakas closed 1 year ago

moustakas commented 1 year ago

Address #123 by switching to the Inoue+14 IGM attenuation coefficients which include DLAs and Lyman-limit systems.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5657121688

74 of 93 (79.57%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 50.797%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
py/fastspecfit/continuum.py	74	93	79.57%
<!--	Total:	74	93	79.57%	-->

Totals
Change from base Build 5656455960:	0.4%
Covered Lines:	2295
Relevant Lines:	4518

💛 - Coveralls

moustakas commented 1 year ago

The differences are ~negligible as far as the modeling is concerned, but the new coefficients are definitely more complete / correct.

Fuji/v2.0:

this branch:

fastspec /global/cfs/cdirs/desi/spectro/redux/fuji/healpix/sv3/dark/91/9151/redrock-sv3-dark-9151.fits --targetids 39632981379255270 -o fastspec.fits
fastspecfit-qa fastspec.fits