search

desihub / fastspecfit

Fast spectral synthesis and emission-line fitting of DESI spectra.
https://fastspecfit.readthedocs.org
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

boxflux is incorrect #138

Closed moustakas closed 1 year ago

moustakas commented 1 year ago

I don't think boxflux is widely used, but it is not being computed correctly. In emlines.EMFitTools.population_emtable, I am doing a straight sum of the pixels rather than an integration. Blarg.

moustakas commented 1 year ago

Fixed in https://github.com/desihub/fastspecfit/pull/137/commits/97b52a907c9679481fa547757b1f7f4a7169d9f6.

yuvoonng commented 1 year ago

@moustakas This has also been my long concern. Does this issue apply to and affect the LINE_FLUX_IVAR as well? Thank you for your time.