search

desihub / fastspecfit

Fast spectral synthesis and emission-line fitting of DESI spectra.
https://fastspecfit.readthedocs.org
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

Tutorial and flux_ivar change #143

Closed ashodkh closed 1 year ago

ashodkh commented 1 year ago

I added a tutorial that shows how to obtain the fastspecfit and observed healpix spectra of an object in the fastspecfit catalog. I also squared the weights in the flux_ivar calculation. The sum of the weights was already squared, but the weight itself in np.sum (weights/line_ivar) should also be squared.

moustakas commented 1 year ago

@ashodkh thank you for this contribution!

As you may have seen, there has been a lot of activity on the code base, including on the flux_ivar bug fix that you've included in this PR. Could you please either close this PR and reopen a new PR with just your notebook or merge with main and fix the conflict(s) in emlines.py?

Also, your notebook is great but could you please add a few more "header" details, including your name and affiliation and instructions for how to load the dependencies? For example, here's a nice tutorial that @geordie666 wrote for working with targeting bits that you can use as a model-- https://github.com/desihub/desitarget/blob/main/doc/nb/target-selection-bits-and-bitmasks.ipynb

Thanks again.