Closed moustakas closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
py/fastspecfit/fastspecfit.py | 4 | 8 | 50.0% | ||
py/fastspecfit/emlines.py | 40 | 52 | 76.92% | ||
py/fastspecfit/io.py | 20 | 40 | 50.0% | ||
py/fastspecfit/continuum.py | 101 | 148 | 68.24% | ||
<!-- | Total: | 167 | 250 | 66.8% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
py/fastspecfit/emlines.py | 1 | 51.31% | ||
py/fastspecfit/io.py | 187 | 54.72% | ||
py/fastspecfit/continuum.py | 219 | 72.95% | ||
<!-- | Total: | 407 | --> |
Totals | |
---|---|
Change from base Build 5812793938: | -0.01% |
Covered Lines: | 2454 |
Relevant Lines: | 4090 |
This PR includes a variety of fixes and updates and is a
2.3.1
release candidate.Highlights include:
2.3.0
tests when one or more cameras on the first spectrum in a given healpixel is fully masked.2.3.0
.xtol
convergence criterion parameter inscipy.optimize.least_squares
from 1e-2 to its default (1e-8) to prevent the optimization from stopping before actual convergence. One example where this matters issv3-bright-25918-39627758090851408
. I also removed the requirement that the final velocity widths and centers cannot change by more than +/-20% during the final round of fitting. I found that objects likesv3-bright-25918-39627758090851408
require the additional flexibility after some of the constraints are relaxed in the final iteration. I will need to do some additional larger-scale tests to ensure this change doesn't introduce other problems, however._FLUX
and_FLUX_IVAR
parameters are now derived using the method documented in https://github.com/desihub/fastspecfit/issues/127#issuecomment-1677443903. See the full thread in #127 for additional details and caveats regarding these parameters.