desihub / fastspecfit

Fast spectral synthesis and emission-line fitting of DESI spectra.
https://fastspecfit.readthedocs.org
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

incorrect syntax synthesizing photometry for highest-redshift targets #152

Closed moustakas closed 12 months ago

moustakas commented 1 year ago

The Iron/v2 VAC ran nearly to completion with tag 2.4.1 but there was a corner-case bug I had previously fixed, recently messed with, and broke again. The issue only impacts the handful of objects in the sample (spanning approximately 50 healpixels) at the highest redshifts (z>5.3 or so) where I have to extrapolate / pad the best-fitting model while synthesizing photometry and computing K-corrections. The error was in the syntax of the padding / extrapolation with speclite.filters.pad_spectrum.

I also added a couple options for generating merged catalogs by survey type (merging over all programs): main, sv={cmx,sv1,sv2,sv3}, and special.

I'm going to do a few more checks and then tag 2.4.2 and finish the Iron VAC.

github-actions[bot] commented 12 months ago

Pull Request Test Coverage Report for Build 6025767125


Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/continuum.py 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Totals Coverage Status
Change from base Build 5955234517: 0.0%
Covered Lines: 2471
Relevant Lines: 4170

💛 - Coveralls