search

desihub / fastspecfit

Fast spectral synthesis and emission-line fitting of DESI spectra.
https://fastspecfit.readthedocs.org
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

Error when using the stackfitting routine #154

Closed dirkscholte closed 11 months ago

dirkscholte commented 11 months ago

I got an error when running the stackfitting routine: File "/global/common/software/desi/perlmutter/desiconda/20230111-2.1.0/code/fastspecfit/2.4.0/lib/python3.10/site-packages/fastspecfit/continuum.py", line 2298, in continuum_specfit kcorr, absmag, ivarabsmag, _, synth_bestmaggies = CTools.kcorr_and_absmag( ValueError: not enough values to unpack (expected 5, got 4)

Should this line: https://github.com/desihub/fastspecfit/blob/ab5570c7294b6ab3c78a4cd0d7baf8135a16dee6/py/fastspecfit/continuum.py#L2304

be this instead now: kcorr, absmag, ivarabsmag, synth_bestmaggies = CTools.kcorr_and_absmag( ?

I've made the change locally and other than that it all seems to run fine! The fastqa doesn't work on the stacked files like the fastspecfit-qa used to but I think that's just due to it not knowing the new uniqueid and photsys inputs.

moustakas commented 11 months ago

Thanks for the bug report, @dirkscholte; apologies for the hassle. Please feel free to open a PR with whatever fix you think is appropriate. We really need some unit tests for fitting stacked spectra; I suspect I will continue to break this mode!

dirkscholte commented 11 months ago

Done.

FYI the fastqa works perfectly fine for stacking. I had just forgotten to add the --stackfit flag to the command in the terminal. 🙃

moustakas commented 11 months ago

Fixed in #155.