Closed moustakas closed 1 day ago
@jdbuhler has pointed out that when one component of a doublet (e.g., [OII] 3726) is dropped during optimization, the companion member of the doublet (e.g., [OII] 3729) isn't dropped.
Specifically, something like
lineamps[doubletindx] *= lineamps[doubletpair]
should be added here, right after the tied constraints are applied: https://github.com/desihub/fastspecfit/blob/main/py/fastspecfit/emlines.py#L972-L975
It looks like this bug impacts roughly 17,000 (out of 18M) [OII] measurements in Iron (<0.1%), and just ~700 objects (out of 1.4M) in Fuji.
Iron
Fuji
Fixed in #177.
moustakas
commented
1 day ago
@jdbuhler has pointed out that when one component of a doublet (e.g., [OII] 3726) is dropped during optimization, the companion member of the doublet (e.g., [OII] 3729) isn't dropped.
Specifically, something like
should be added here, right after the tied constraints are applied: https://github.com/desihub/fastspecfit/blob/main/py/fastspecfit/emlines.py#L972-L975
It looks like this bug impacts roughly 17,000 (out of 18M) [OII] measurements in
Iron(<0.1%), and just ~700 objects (out of 1.4M) inFuji.