coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 3809189964
- 670 of 1326 (50.53%) changed or added relevant lines in 4 files are covered.
- 7 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-12.2%) to 57.898%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| py/fastspecfit/io.py | 96 | 111 | 86.49% | ||
| py/fastspecfit/continuum.py | 55 | 130 | 42.31% | ||
| py/fastspecfit/emlines.py | 495 | 577 | 85.79% | ||
| py/fastspecfit/fastspecfit.py | 24 | 508 | 4.72% | ||
| <!-- | Total: | 670 | 1326 | 50.53% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| py/fastspecfit/fastspecfit.py | 1 | 21.27% | ||
| py/fastspecfit/emlines.py | 6 | 64.75% | ||
| <!-- | Total: | 7 | --> |
| Totals | |
|---|---|
| Change from base Build 3522749933: | -12.2% |
| Covered Lines: | 2049 |
| Relevant Lines: | 3539 |
moustakas
[WIP]
Still WIP but opening a PR to track related issues.
This PR is a fairly major rewrite of the emission-line fitting engine with an eye toward porting the code to the Perlmutter/GPUs (e.g., https://jaxopt.github.io/stable/constrained.html). Specifically, all the
astropy.modelingroutines have been replaced with a simpler table-basedlinemodelof parameters (including tied parameters), resulting in about 300 fewer lines of code and notable speed-ups.However, the speed-ups have been used to include one additional (third) round of fitting where emission lines are minimally constrained to one another, which leads to notable improvements in the line-fitting results for systems with complex line-kinematics (and to account for any cross-camera wavelength-calibration issues).
Second, I've moved away from the home-grown
fnnlsalgorithm for continuum fitting and am now just usingscipy.optimize.nnlswhich I also hope to be able to port to a GPU.