desihub / fiberassign

Fiber assignment code for DESI
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

always propagate *_TARGET columns #296

Closed sbailey closed 3 years ago

sbailey commented 3 years ago

Always propagate all _TARGET columns from the input target/mtl files to the output fiberassign files, even if that column is all zeros (e.g. DESI_TARGET during SV). Future-proof this with something like if colname.endswith('_TARGET') or a regex match so that it will automatically include future _TARGET columns that we haven't even invented yet (SV2_DESI_TARGET, LIGO_TARGET, DESI2_TARGET, ...).

Credit to @djschlegel for the "future proofing" idea of propagating all *_TARGET columns instead of specifically opt-in like other columns.

araichoor commented 3 years ago

PR #297 addresses that issue.