desihub / fiberassign

Fiber assignment code for DESI
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

Discard 18<G<19 STD_FAINT as std for Main BRIGHT tiles #411

Open araichoor opened 2 years ago

araichoor commented 2 years ago

The current behavior is to consider at the same level STD_BRIGHT (16<G<18) and STD_FAINT (16<G<19) targets for Main BRIGHT and DARK tiles: https://github.com/desihub/fiberassign/blob/33c15ad9904091d185e6329a7f6f6e2575e81ed1/py/fiberassign/targets.py#L230-L237

Quoting from @djschlegel : The STD_BRIGHT,STD_FAINT behavior on the dark tiles in correct. Most standards are labeled as both. On the bright tiles, it appears we’re getting an identical distribution of standard stars — spanning r=[16,19] — which is 1 mag fainter than they should be. So… it appears the STD_FAINT-only stars at r=[18,19] are getting selected for the bright tiles, which was not the intention.

araichoor commented 2 years ago

Copying here comment made on https://github.com/desihub/fiberassign/issues/410 by @schlafly:

"For the STD_BRIGHT vs STD_FAINT thing, I haven't fully understood if we're doing what we want. My sense is that we'd rather have brighter standards than fainter standards always. If such a change were made I don't think we'd want to get rid of STD_FAINT for BRIGHT; they're just a fall back if not enough standards are available.

In practice we're taking both with no priorities, but it's not obvious to me that we wouldn't like the faint ones on BRIGHT tiles if no bright ones were available."

araichoor commented 2 years ago

Thanks for that input. As you say, I think fiberassign does not know about priorities for the standards, those are just dealt with as a single set for the assignment. So the options would be to either keep things as they are or remove the 18<G<19 STD_FAINT for the bright tiles (and backup also?).

What I could do:

djschlegel commented 2 years ago

That would be great. If keeping only STD_BRIGHT delivers enough standards on all tile+petals, then we have a simple solution of just dropping STD_FAINT on the bright-time tiles. Otherwise, we're in a situation where the logic would need to be somewhat more complex since there are already priority considerations on the targets that get bumped. I suppose we would have to run through the loop of assignment of standard stars twice: first for STD_BRIGHT, then again for STD_FAINT.

araichoor commented 2 years ago

Ok, so here is a report of that small exercise; happy to discuss that tomorrow.

Foreword:

Method: I did run for the 1427 bright pass=0, in_desi, tiles the fiber assignment, with rundate=2021-10-02T00:00:00+00:00. Note that, as I m running with MTL, fiberassign will account for the MTL status of the already observed targets. I used the code from https://github.com/desihub/fiberassign/pull/415, which discards the STD_WD from the standard counting. I made two runs:

Results: As expected, removing the 18<G<19 STD_FAINT from the standard counting boosts the number of assigned STD_BRIGHT from ~5 to ~10. Here is a comparison plot (per TILEID-PETAL) for the assigned STD_BRIGHT:

tmp-std_bright

Though, there are 10% (resp. ~2%) of the TILEID-PETAL which have less than 10 (resp. 5) assigned STD_BRIGHT; their sky distribution: tmp-sky-stdbright Those regions in green are consistent with a lower density of STD_BRIGHT, e.g. here: https://data.desi.lbl.gov/desi/users/adamyers/1.1.1/main/desitargetQA-dr9-bright-1.1.1/skymap-STD_BRIGHT.png

If one considers the assigned STD_FAINT, i.e. what will be used by the spectroscopic pipeline, the fraction of TILEID-PETAL with less than 10 assigned STD_FAINT drops to ~6% (covering the inner regions of the green dots above):

tmp-std_faint

However, I think that we should consider this last result carefully: because I think that those assigned STD_FAINT-only targets are getting a fiber because of their MWS_MAIN_BLUE status, as they have lost their "standard" status, and hence follow the rules of PRIORITY and NUMOBS; so it could be more like ~10% when several passes are already done.

In the current scheme (STD_BRIGHT, STD_FAINT as standards), 1% only of TILEID-PETAL have STD_FAINT < 10.