desihub / fiberassign

Fiber assignment code for DESI
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

nosteps in fba_rerun #427

Open araichoor opened 2 years ago

araichoor commented 2 years ago

Apparently the handling of the steps/nosteps arguments in fba_rerun is not properly done. In fba_rerun, steps/nosteps are arguments of the script, ie can overrule what is stored in the fiberassign FAARGS header. I guess the initial thought was for instance to disable the qa step when running reproducibility tests.

I tried to reproduce tileid=82637: this tile is a tertiary (prognum=1) file, where fba_launch is called in a special mode, with --nosteps scnd --targ_std_only --too_tile --custom_too_file $TOOFN. The --nosteps scnd disables the query of the secondary targets catalogs.

However, when running fba_rerun on tileid=82637, it runs with the scnd step, hence failing to exactly reproduce the assignment/potential_assignments.