search

desihub / fiberassign

Fiber assignment code for DESI
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

Add old script for patching fiberassign files (from Oct 5/2021) #434

Closed dstndstn closed 1 year ago

dstndstn commented 2 years ago

This PR adds bin/patch-fa.py, the script I ran to patch the fiberassign files the first time! Doesn't touch any other files.

araichoor commented 1 year ago

hi @dstndstn,

my sincere apologies, I somehow totally overlooked this PR. it would indeed be great to officially record that file. I m thinking: maybe we could rename it? like e.g. fba_patch_202110?

ps: we also definitely should save the associated log files; we ll keep you updated on the preferred location.

dstndstn commented 1 year ago

Hi @araichoor I renamed as you suggested :)

araichoor commented 1 year ago

great, thanks. I ll merge that on Monday.

in the meantime, let s also update the doc/changes.rst file (I can take care of that), as I try to transition to the cleaner habit of updating that file for each PR (instead of doing that when creating a tag). see PR https://github.com/desihub/fiberassign/pull/440, that I ll probably merge on Monday.

araichoor commented 1 year ago

the PR https://github.com/desihub/fiberassign/pull/440 about doc/changes.rst got stalled by suggested improvements... and I ve opened a separate ticket to decide how to record the log files of the patching process.

so I I m going to merge this PR (and I ll deal with the doc/changes.rst when closing PR https://github.com/desihub/fiberassign/pull/440).

thanks @dstndstn!