search

desihub / fiberassign

Fiber assignment code for DESI
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

fba_sv1 not fixed for row-mixing issue #443

Closed araichoor closed 1 year ago

araichoor commented 1 year ago

While doing the fiberassign patching exercise, I noticed that the fba_sv1 script has not been fixed for this row-mixing issue. https://github.com/desihub/fiberassign/blob/53199d2a8cd01240c1308c78a70bce0ddddaedf1/bin/fba_sv1#L1646 That line should be removed.

For reference, the PR fixing the row mixing issue in 'fba_launch_io.py: https://github.com/desihub/fiberassign/pull/375. fba_cmx` has been fixed (PR https://github.com/desihub/fiberassign/pull/400).

I doubt we will ever use again fba_sv1, but let s fix that.

araichoor commented 1 year ago

fixed in PR https://github.com/desihub/fiberassign/pull/444; closing.