Closed dstndstn closed 1 year ago
The unit tests are failing because https://github.com/desihub/desimodel/pull/170 is not merged yet
sorry @dstndstn for the delay in reviewing! I had a look at the code, but it s a bit technical for me, so I fully trust you here :)
I ve done the following sanity check: rerun all the observed main survey with the main branch and with your pr460 branch: the outputs do exactly match, so perfect!
could you just:
load_hardware_args()
function?then I ll merge it.
Okay, @araichoor , thanks for the checks! I added the things you mentioned (and a few other improvements!) Should be good to go!
Thanks @dstndstn @araichoor. Merging now to include in the next tag.
This is needed for some LSS optimization work: https://github.com/desihub/LSS/pull/101
load_hardware_args()
function that returns the arguments that should be passed to theHardware()
constructor -- useful when used withmultiprocessing
/pickle
; and also returns the time validity range for that hardware configurationget_time_range
kwarg toload_hardware()
to return the datetime range when that hardware configuration is validHardware()
constructor, which was doing a 5000 x 5000 neighbor-search of positioners. Speed this up by argsorting on the X coordinate and using that to search only positioners in the X slice that could possibly be neighbors.