desihub / fiberassign

Fiber assignment code for DESI
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

Speed up the Hardware() constructor, and other optimizations #460

Closed dstndstn closed 1 year ago

dstndstn commented 1 year ago

This is needed for some LSS optimization work: https://github.com/desihub/LSS/pull/101

dstndstn commented 1 year ago

The unit tests are failing because https://github.com/desihub/desimodel/pull/170 is not merged yet

araichoor commented 1 year ago

sorry @dstndstn for the delay in reviewing! I had a look at the code, but it s a bit technical for me, so I fully trust you here :)

I ve done the following sanity check: rerun all the observed main survey with the main branch and with your pr460 branch: the outputs do exactly match, so perfect!

could you just:

then I ll merge it.

dstndstn commented 1 year ago

Okay, @araichoor , thanks for the checks! I added the things you mentioned (and a few other improvements!) Should be good to go!

sbailey commented 1 year ago

Thanks @dstndstn @araichoor. Merging now to include in the next tag.