search

desihub / gpu_specter

Scratch work for porting spectroperfectionism extractions to GPUs
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Refactor code structure and patch bookkeeping #23

Closed sbailey closed 4 years ago

sbailey commented 4 years ago

This PR refactors the code structure and updates the patch bookkeeping in the hopes of making that easier to maintain. The GPU extractions are completely broken (not just wrong, but won't run). This PR uses @dmargala 's rebased fix of my munged history refactor branch (Thanks!).

I'm ok with either merging this now as-is and then opening tickets and then working on making it "correct" (i.e. matching current desi_extract_spectra + specter), or otherwise doing a bit more work on correctness in this branch (or PRs against this branch) before merging to master. I think the consensus yesterday was to go ahead and merge, but wanted to double check.

@lastephey @dmargala @ziyaointl ?

dmargala commented 4 years ago

That sounds good to me. I think there have been a few files added to master that will need to be "refactored" to match the new folder scheme but that can be done in a new issue/PR.

lastephey commented 4 years ago

merge away