desihub / gpu_specter

Scratch work for porting spectroperfectionism extractions to GPUs
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Fixes PSF coeff evaluation #25

Closed sbailey closed 4 years ago

sbailey commented 4 years ago

This PR

Although the evaluated coefficients now agree, the evaluated spots do not yet agree. The next step will be to add tests that spots agree (they don't) and debug that, then proceed with testing+debugging projection_matrix and ex2d_patch.

The tests are not yet integrated into Travis or CircleCI, but they can be run with

python setup.py test
lastephey commented 4 years ago

Looks good to me @sbailey

+1 for cleaning up the psf bookkeeping +1 for unit tests

Both tests passed-- it seems like we'll need to write some more tests that fail to help us debug. I assume this will be in a future PR. :)

I'll leave it to @dmargala to comment and merge if he chooses