Closed sbailey closed 1 month ago
Here are the elements to produce new QSO PCAs from SDSS data:
To get a better redshift, we can use a ladder from galaxies:
Added three files to calibrate the ivar, the flux and veto some sky lines.
I like these steps, with one suggestion to consider for the first step of building the PCA from an expanding redshift ladder: Consider tying the initial low redshift QSO sample to a custom fit of the sharp [OIII] 4959 and 5007 lines (and maybe Hbeta 4861) instead of using a second-best galaxy template fit redshift.
It would be great to get these templates into desisim
, not just redrock
....
@abrodze @dylanagreen can you please assess this ticket and close it if it's no longer relevant wrt the current set of QSO templates?
@moustakas I believe, and @abrodze can correct me if I'm wrong, that her newly generated templates (the lya ones) correct for this effect up to using the Kamble/Calura model, and my templates that I've been working on use the Inoue model.
Based on this then any template set that will be used for Y3 (either the LYA ones or my NMF ones) will correct for this effect using one of the two aforementioned models, but that the templates used in Iron/Y1 did not correct for this effect, again hoping Allyson can correct me if this is wrong.
Probably since this issue is thus fixed moving forward (Y3 and beyond) I am in favor of closing it but I'll leave the final decision on this to someone else.
PR #104 corrects for mean LyA while doing the QSO redshift scan, but it still uses the old QSO templates from BOSS that didn't remove LyA while building them. Create a new set of QSO templates that also remove mean LyA while building the templates.
PR #104 showed an example of this, but there was a strange notch in the templates at LyA, appearing as if some of the input QSOs had the wrong z and were thus mis-corrected.
These updated templates along with #104 should provide more consistent results on real data, but should also be coordinated with an update to simqso (or the desispec wrapper of simqso) since those templates also include mean LyA, and then additional LyA absorption is included on top of that (ugh).