search

desihub / redrock

Redshift fitting for spectroperfectionism
BSD 3-Clause "New" or "Revised" License
22 stars 14 forks source link

Add support for different templates using different IGM models #269

Closed sbailey closed 8 months ago

sbailey commented 8 months ago

For future templates, we seem to have converged on Inoue14 as the best IGM model. However, we would still like to be able to evaluate old templates with the latest Redrock code, even if those templates were trained with a different IGM model.

Proposal: add new header keyword RRIGM that defines which IGM model to use: Inoue14, Calura12, Kamble20, and then propagate that choice to transmission_Lyman which would select the model to use. Include support for past templates which don't have the RRIGM keyword, using their version number to know which model to use.

I'm working on this, but am filing this ticket for tracking.

moustakas commented 8 months ago

Probably done in #271 @sbailey?

sbailey commented 8 months ago

Yes, thanks for noticing this dangling ticket. For the record, this was implemented in PR #271, where templates now have a header keyword RRIGM to specify which IGM model to use. Supported values are Calura12, Kamble20, and Inoue14. I put in support for legacy templates to derive which model to use based upon their version number, but IIRC this is now a required keyword for new templates.