search

desihub / specex

DESI spectrograph PSF fitting
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Remove calls to boost::numeric::ublas #41

Closed marcelo-alvarez closed 3 years ago

marcelo-alvarez commented 3 years ago

All calls to boost::numeric::ublas methods project, range, and noalias have been removed without changing the functionality or performance of specex. Results are bitwise identical to the result from master branch with the same wall clock run time to about a percent.

Please check it builds as expected and merge into master.

sbailey commented 3 years ago

I confirmed that it builds as expected; I will trust your tests for bitwise and timing comparisons. Looks good.